3.9 local change reviews and merges with trunk

Tuesday, October 26th, 2010|Version 3|by Romans
Mini review of patches which are being moved from 3.9 to trunk.
Agile Toolkit 3.9 -> trunk merges.
1466 - mysql::tableHasField() method added
fragmental change but seems fine.
MERGING
1467 - Fixed saving login to cookies
good change.
MERGING
1469 - Some fixes to TMail Notice: TMail was and remains not-working, it requires complete remake
i agree on re-make. However without <sign> it seems to work fine.
NOT MERGING
(copy TMail locally)
1472 – Form: making isClicked() working
Potentially dangerous. It made all buttons in the form submit it. Such as button next to autocomplete.
Partially reversed in 1509.
NOT MERGING
1474 – This change now allows you to throw RenderCompleted exceptions from pre-render hook
ALREADY MERGED
1475 - Add ability for fields to be cut out (their getInput part) to work with sync with ui.atk4_form / reloadField Also improv…
1485 - include JS output even when cutting field
ALREADY MERGED
Test case: http://demo.atk4.com/demo.html?t=20
1478 - Backport – improved JS encapsulation from PHP, better protection against JS injeciton
ALREADY MERGED
Test case: http://demo.atk4.com/demo.html?t=11
1480 - ApiFronted::loadStaticPage() added
MERGING
improves reusability, will merge
1487 – ui.atk4_form: removed excessive “Form loading…” message
NOT MERGING
possibly because of 1472
1490 - BasicAuth: loginRedirect() functionality restored
1492 - BasicAuth: saveDestinateion() fix
NOT MERGING
possibly in need of refactoring.
1493 - returned options to frame
MERGING
thanks
1496 - code cleanup
need to review / provide test cases
MERGING
1498 - button template fix
weird fix. Why remove ID from element? Can you comment?
NOT MERGING
1500 - fix or notfix
Compatibility fix with 5.3. Already merged.
ALREADY MERGED
1505 − 451
last_field is obsolete. shouldn’t be used.
NOT MERGING
1506 - Grid: adding class to TH
I don’t see how it’s useful but can merge
MERGING
1509 - form – do not automatically bind form’s buttons (also adds support for trees)
MERGING
1512 – makes it easier for you to redefine paginator’s URLs
better OOP,
MERGING

Write a comment